Skip to content

Try to make rename work#33

Closed
enj wants to merge 6 commits intoopenshift:masterfrom
enj:enj/i/sally_fix_name
Closed

Try to make rename work#33
enj wants to merge 6 commits intoopenshift:masterfrom
enj:enj/i/sally_fix_name

Conversation

@enj
Copy link
Contributor

@enj enj commented Jan 21, 2019

No description provided.

@enj enj requested review from sallyom and stlaz January 21, 2019 03:33
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 21, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2019
@enj
Try to fix issues caused by rename
9200dd7 
Signed-off-by: Monis Khan <mkhan@redhat.com>
@enj enj force-pushed the enj/i/sally_fix_name branch from c88c6e4 to 9200dd7 Compare January 21, 2019 03:37
@enj enj removed the request for review from soltysh January 21, 2019 03:46
@enj
Undo changes to Dockerfile
df704f1 
Signed-off-by: Monis Khan <mkhan@redhat.com>
@enj enj force-pushed the enj/i/sally_fix_name branch from c661f89 to df704f1 Compare January 21, 2019 05:20
stlaz
stlaz reviewed Jan 21, 2019
View reviewed changes
hack/lib/constants.sh

readonly OS_CROSS_COMPILE_TARGETS=(
cmd/osin-operator
cmd/authentication-operator
Copy link
Contributor

@stlaz stlaz Jan 21, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to mv cmd/{osin,authentication}-operator too

edit: moved it myself in the following patch

@stlaz
Copy link
Contributor

stlaz commented Jan 21, 2019

Pushed a patch to fix the CI build error.

@stlaz
Copy link
Contributor

stlaz commented Jan 21, 2019

Getting the good old RetryWatcher and timeout errors now, feels like progress...
/retest

@stlaz
Copy link
Contributor

stlaz commented Jan 21, 2019

Needs the suggested changes, otherwise LGTM. Keeping origin- in the earlier commits was puzzling to me, but this was luckily fixed in later commits.

It seems that CI still feels sad 😞
/retest

@stlaz stlaz mentioned this pull request Jan 21, 2019
Closed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 21, 2019

@enj: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-operator a63b03c link /test e2e-aws-operator
ci/prow/e2e-aws a63b03c link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enj
Copy link
Contributor Author

enj commented Jan 21, 2019

#34

@enj enj closed this Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sallyom sallyom Awaiting requested review from sallyom

@ericavonb ericavonb Awaiting requested review from ericavonb

1 more reviewer

@stlaz stlaz stlaz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@enj @openshift-ci-robot @stlaz @sallyom